Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --list, --ignored and --exact to wasm-bindgen-test-runner #4356

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Dec 15, 2024

This PR intends to add support for nextest to wasm-bindgen-test-runner. For the requirements see the nextest documentation.

  • Add --list and the corresponding --format. We only support the terse format and only together with --list.
  • Add --ignored.
  • Add --exact.
  • Add --nocapture. Browsers now show console.*() calls in-place instead of after test results, analogous to cargo test.

While this PR now makes wasm-bindgen-test-runner work with cargo nextest, there are a couple of caveats:

  • Spawning the driver takes a non-trivial amount of time. This can already be addressed by using *DRIVER_REMOTE. That said, geckodriver doesn't support parallel sessions.
  • Creating sessions takes a non-trivial amount of time. The solution here probably involves creating some sort of session manager that can be spawned via wasm-bindgen-test-runner.
  • wasm-bindgen takes a non-trivial amount of time when not compiled with the release profile. While this isn't an issue for users, its an issue for our CI. We can still improve the situation further by caching the post-processed output.

Replaces #3920.
Addresses #3891.

@daxpedda daxpedda force-pushed the test-list branch 2 times, most recently from f6cfc41 to 2813118 Compare December 16, 2024 07:52
@daxpedda daxpedda changed the title Add --list argument to `wasm-bindgen-test-runner Add --list argument to wasm-bindgen-test-runner Dec 16, 2024
@daxpedda daxpedda force-pushed the test-list branch 3 times, most recently from cb98a71 to 5d9af65 Compare December 16, 2024 21:40
@daxpedda daxpedda changed the title Add --list argument to wasm-bindgen-test-runner Add --list and --ignored to wasm-bindgen-test-runner Dec 16, 2024
@daxpedda daxpedda changed the title Add --list and --ignored to wasm-bindgen-test-runner Add --list, --ignored and --exact to wasm-bindgen-test-runner Dec 16, 2024
@daxpedda daxpedda force-pushed the test-list branch 3 times, most recently from cff8972 to 964f5e9 Compare December 17, 2024 17:11
@daxpedda daxpedda marked this pull request as ready for review December 17, 2024 18:22
@daxpedda daxpedda merged commit 54034a5 into rustwasm:main Dec 17, 2024
67 checks passed
@daxpedda daxpedda mentioned this pull request Dec 17, 2024
21 tasks
daxpedda added a commit to daxpedda/wasm-bindgen that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant