Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: add missing and fix incorrect testing info #3629

Merged
merged 2 commits into from
Sep 21, 2023
+5 −2
Merged

guide: add missing and fix incorrect testing info #3629

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cce8dcb
guide: add missing and fix incorrect testing info
flumm Sep 21, 2023
6c6501a
guide: improve macro test invocation
flumm Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions guide/src/contributing/testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ These are the largest test suites, and most common to run in day to day
Node.js or a headless browser via the WebDriver protocol.

```bash
cargo test --target wasm32-unknown-unknown
WASM_BINDGEN_SPLIT_LINKED_MODULES=1 cargo test --target wasm32-unknown-unknown
```

See [the `wasm-bindgen-test` crate's
Expand All @@ -34,8 +34,11 @@ cargo test -p webidl-tests --target wasm32-unknown-unknown
These tests assert that we have reasonable error messages that point to the
right source spans when the `#[wasm_bindgen]` proc-macro is misused.

You can run these tests by running `cargo test` in the `crates/macro` directory:

```
cargo test -p ui-tests
cd crates/macro
cargo test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do this more concisely with cargo test -p wasm-bindgen-macro.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, i missed that. was only looking at the members in the workspace, i'll push a commit shortly

```

## The `js-sys` Tests
Expand Down