-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasm-pack
tests for net
to CI
#486
Merged
ranile
merged 7 commits into
rustwasm:master
from
littlebenlittle:littlebenlittle/ci/net_wasmpack_tests
Jul 21, 2024
+13
−2
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
377ec67
add wasm-pack test for net to ci
littlebenlittle df289af
remove commented line
littlebenlittle 272323c
fix path to net crate
littlebenlittle 66fb932
enable query tests
littlebenlittle 8294631
cfg gate for browser tests
littlebenlittle 65dd70e
revert cargo.lock
littlebenlittle 1e9e002
add browser-test feature
littlebenlittle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
use gloo_net::http::QueryParams; | ||
use wasm_bindgen_test::*; | ||
|
||
#[cfg(feature = "browser_test")] | ||
wasm_bindgen_test_configure!(run_in_browser); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as previous comment |
||
|
||
#[wasm_bindgen_test] | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for browser tests, please keep this in (and gate it behind
wasm32-unknown-unknown
target)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clippy doesn't like
#[cfg(target="wasm32-unkonwn-unknown")]
but it seems to work. Let me know if I misunderstood.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
target_arch
refers to wasm32 in this case (see https://doc.rust-lang.org/reference/conditional-compilation.html#target_arch). That might be why clippy complains. You want to update CI so clippy is also run on wasm32 target.You can look at how wasi is cfg-gated in other parts of the code base and do the opposite of it here. If it's
target_os = "wasi"
then you may be able to donot(target_os = "wasi")
to target browser wasm targetsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this seems like a quirk of
wasm_bindgen_test
. As far as I can tell there's no way straightforward way to run in both node and browser.Here's one suggestion: rustwasm/wasm-bindgen#2571 (comment)
Added to latest commit.