Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native TLS #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

markmehere
Copy link

Solves #30 .

I learnt Rust one week ago! 😁

I think this is the way to go but am open to suggestions. Pretty simple PR for the issue.

Once this PR was implemented:

export USE_NATIVE_TLS=1 && wasm-pack build

...worked without issue. wasm-pack uses ureq in other places - but I never encountered those. Currently this fixes everything I need fixed.

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to binary-install! 😄 ✨✨

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I think we would like to put this behind a feature gate.

Something like:

[features]
native-tls = [ "ureq/native-tls" ]

@markmehere
Copy link
Author

Sounds good. I'll leave it in your hands or let me know if you want any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants