Address further IP address support feedback #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `EndEntityCert::verify_is_valid_for_subject_name` that accepts a `SubjectNameRef` as the subject name to match the certificate against.
ereslibre
force-pushed
the
ip-address-support-feedback
branch
2 times, most recently
from
9eff60d
to
d7c9629
Compare
ctz
reviewed
Jan 6, 2023
ereslibre
force-pushed
the
ip-address-support-feedback
branch
2 times, most recently
from
59c46b8
to
8afa5cc
Compare
djc
reviewed
Jan 6, 2023
djc
reviewed
Jan 6, 2023
src/subject_name/mod.rs
Outdated
|
|
||
| mod verify; | ||
| pub(super) use verify::{check_name_constraints, verify_cert_dns_name, verify_cert_subject_name}; | ||
| pub use verify::{check_name_constraints, verify_cert_subject_name}; |
There was a problem hiding this comment.
But then this change doesn't make much sense? We don't want to make these free functions part of the public API, right, so they should have limited visibility? (Hopefully we can merge #22 soon.) If pub(super) is not enough they should probably become pub(crate).
There was a problem hiding this comment.
Thanks, updated. pub(super) did fit the bill.
ereslibre
force-pushed
the
ip-address-support-feedback
branch
from
8afa5cc
to
18f86ff
Compare
ctz
approved these changes
Jan 9, 2023
|
Merged with a fixup (e69b9df) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nametosubject_nameEndEntityCert::verify_is_valid_for_dns_nameAddresses further feedback provided in #5