-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework dns_names
helper, remove alloc req.
#178
Commits on Sep 18, 2023
-
subject_name: remove comment about required feature
We switched to using `doc_auto_cfg` to automatically indicate in Rustdocs when an item requires a particular feature. This comment about the `dns_name::DnsName` re-export requiring alloc isn't necessary anymore.
Configuration menu - View commit details
-
Copy full SHA for 4e2ef1b - Browse repository at this point
Copy the full SHA 4e2ef1bView commit details -
lib: remove unneeded manual docsrs cfg_attr
We switched to `doc_auto_cfg` and don't need to manually annotate `cfg(feature ...)` annotations for docsrs purposes anymore.
Configuration menu - View commit details
-
Copy full SHA for 839cd93 - Browse repository at this point
Copy the full SHA 839cd93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0682cec - Browse repository at this point
Copy the full SHA 0682cecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12cd0ea - Browse repository at this point
Copy the full SHA 12cd0eaView commit details -
end_entity: rework dns_names to return iter of &str
This is what most consumers of the API are interested in, and avoids needing to export the `GeneralDnsNameRef` and `WildcardDnsNameRef` types.
Configuration menu - View commit details
-
Copy full SHA for f5ace6d - Browse repository at this point
Copy the full SHA f5ace6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for de8b2ec - Browse repository at this point
Copy the full SHA de8b2ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d60950 - Browse repository at this point
Copy the full SHA 8d60950View commit details -
tests: rework
no_subject_alt_names
testWe can express this test with the `expect_cert_dns_names` helper.
Configuration menu - View commit details
-
Copy full SHA for 2350c2e - Browse repository at this point
Copy the full SHA 2350c2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22cebce - Browse repository at this point
Copy the full SHA 22cebceView commit details -
end_entity: fix
dns_names
rustdoc commentPrior to this commit the rustdoc comment on `EndEntityCert.dns_names` mentioned using `verify_is_valid_for_dns_name` and `verify_is_valid_for_at_least_one_dns_name`, but these functions don't exist anymore. This commit updates the comment to point to `EndEntityCert::verify_is_valid_for_subject_name`, and does so with a proper Rustdoc link so that future updates will be caught by `cargo doc` if we forget to fix this reference to match.
Configuration menu - View commit details
-
Copy full SHA for 7ffbabe - Browse repository at this point
Copy the full SHA 7ffbabeView commit details
Commits on Sep 20, 2023
-
end_entity: make
dns_names
infallibleThe purpose of the `dns_names` helper on an `EndEntityCert` is to provide users the opportunity to get information on the dNSName SAN values in a certificate for **non-validation** purposes. Checking that a certificate is valid for a particular name should always be done with `verify_is_valid_for_at_least_one_dns_name`. With that use-case in mind, we can make the `dns_names` helper easier for consumers to use by filtering out invalid general names, returning an `Iterator<Item = &'a str>` unconditionally, instead of a `Result`. This better matches the updated name validation semantics where we ignore `MalformedDnsIdentifier` errors to continue to try to find a valid name to validate against.
Configuration menu - View commit details
-
Copy full SHA for 8bf4fa9 - Browse repository at this point
Copy the full SHA 8bf4fa9View commit details -
lib: rm alloc req. for
dns_names
With the update to the `dns_names` function in the previous commit we can now make `EndEntity.dns_names` work without requiring `alloc`.
Configuration menu - View commit details
-
Copy full SHA for 807df74 - Browse repository at this point
Copy the full SHA 807df74View commit details -
subject_name: tidy up
list_cert_dns_names
Avoid combinator chaining, use explicit `match`.
Configuration menu - View commit details
-
Copy full SHA for be4dba6 - Browse repository at this point
Copy the full SHA be4dba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4332b8c - Browse repository at this point
Copy the full SHA 4332b8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 415c387 - Browse repository at this point
Copy the full SHA 415c387View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7aa0f8d - Browse repository at this point
Copy the full SHA 7aa0f8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0522c0 - Browse repository at this point
Copy the full SHA d0522c0View commit details -
Use as_str() method to reference DnsNameRef contents
The From impl feels a little unidiomatic because the DnsNameRef is not consumed. An AsRef impl would unnecessarily constrain the lifetime of the output value to `&self`, whereas it can live as long as `'a`.
Configuration menu - View commit details
-
Copy full SHA for b11327b - Browse repository at this point
Copy the full SHA b11327bView commit details -
Use as_str() method to reference WildcardDnsNameRef contents
The From impl feels a little unidiomatic because the WildcardDnsNameRef is not consumed. An AsRef impl would unnecessarily constrain the lifetime of the output value to `&self`, whereas it can live as long as `'a`.
Configuration menu - View commit details
-
Copy full SHA for abf970c - Browse repository at this point
Copy the full SHA abf970cView commit details -
Use as_str() method to reference GeneralDnsNameRef contents
The From impl feels a little unidiomatic because the GeneralDnsNameRef is not consumed. An AsRef impl would unnecessarily constrain the lifetime of the output value to `&self`, whereas it can live as long as `'a`.
Configuration menu - View commit details
-
Copy full SHA for f470c07 - Browse repository at this point
Copy the full SHA f470c07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e92abf - Browse repository at this point
Copy the full SHA 1e92abfView commit details -
cert: move
list_cert_dns_names
toCert
This commit lifts the free-standing `list_cert_dns_names` helper from the `subject_name` module to be associated with a `Cert`. Doing so also requires making the `subject_name::NameIterator` and `subject_name::WildcardDnsNameRef` `pub(crate)` visible.
Configuration menu - View commit details
-
Copy full SHA for 64fb1b7 - Browse repository at this point
Copy the full SHA 64fb1b7View commit details