disable nginx session tickets for resumption test #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Nginx 1.24.0 we saw a regression in the runner `nginx` test when checking that session resumption worked as expected with a `curl` client. This commit fixes the issue by disabling `ssl_session_tickets` for the server config using `ssl_session_cache shared:...` (port 8446). Since Nginx 1.23.2, the `shared` session cache has done double duty, also managing generating, storing, and updating TLS session ticket keys. This is done primarily with the OpenSSL `SSL_CTX_set_tlsext_ticket_key_cb`/`SSL_CTX_set_tlsext_ticket_key_evp_cb` APIs, which we don't yet support. We're also not setting a ticketer for the Rustls `ServerConfig` we construct. The net result is that when using our compat shim with Nginx 1.23.2+ we need to explicitly disable session ticket support in order for the `shared` session cache to work the way we expect for classic sessions.
This was referenced Jun 26, 2024
ctz
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Nginx 1.24.0 we saw a regression in the runner
nginxtest when checking that session resumption worked as expected with acurlclient (#30). This branch fixes the issue by disablingssl_session_ticketsfor the server config usingssl_session_cache shared:...(port 8446).Since Nginx 1.23.2 (nginx/nginx@1d572e3), the
sharedsession cache has done double duty, also managing generating, storing, and updating TLS session ticket keys. This is done primarily with the OpenSSLSSL_CTX_set_tlsext_ticket_key_cb/SSL_CTX_set_tlsext_ticket_key_evp_cbAPIs, which we don't yet support. We're also not setting a ticketer for the RustlsServerConfigwe construct.The net result is that when using our compat shim with Nginx 1.23.2+ we need to explicitly disable session ticket support in order for the
sharedsession cache to work the way we expect for classic sessions.Separately, we should investigate proper session ticket support. In the meantime this restores the testing we intended to be happening and clarifies where the limitation is.
Updates #30