0.14.1 release preparation #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar fixes were incrementally landed on main.
Nightly clippy's `clippy::zombie_processes` lint flagged the following:
```
error: spawned process is never `wait()`ed on
--> tests/client_server.rs:285:26
|
285 | let mut server = self.server_opts.run_server();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: consider calling `.wait()`
= note: not doing so might leave behind zombie processes
= note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes
```
While we _do_ call `kill()` on the process, we weren't `wait()`ing it.
The `Process::Child` docs have a warning:
On some systems, calling wait or similar is necessary for the OS to
release resources. A process that terminated but has not been waited on
is still around as a “zombie”. Leaving too many zombies around may
exhaust global resources (for example process IDs).
So it seems it may not be sufficient on all systems to `kill()` without
`wait()`.
Let's add a `wait()` just to be sure. Nobody likes zombies.
```
error: this `match` expression can be replaced with `?`
--> src/crypto_provider.rs:466:20
|
466 | let provider = match provider_from_crate_features() {
| ____________________^
467 | | Some(provider) => provider,
468 | | None => return None,
469 | | };
| |_____^ help: try instead: `provider_from_crate_features()?`
```
This matches upstream rustls.
ctz
requested changes
Nov 22, 2024
Notably this brings in a fix for an availability issue for **servers** using the `rustls_acceptor` type and associated APIs. See the upstream 0.23.18 release notes for more information.
ctz
approved these changes
Nov 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release updates to Rustls 0.23.18 and increases the project MSRV from 1.64 to 1.71, matching the upstream Rustls MSRV.
Notably this brings in a fix for an availability issue for servers using the
rustls_acceptortype and associated APIs. See the upstream 0.23.18 release notes for more information.This branch targets rel-0.14, created from the 0.14.0 tag.