Skip to content

Commit

Permalink
proj: MSRV 1.71 -> 1.73
Browse files Browse the repository at this point in the history
1.71 and 1.72 both hit an ICE building with a static reference to
Rustls' aws-lc-rs HPKE suites. Upstream (sensibly) isn't interested in
fixing bugs in old compilers. We also don't want to bump the upstream
Rustls MSRV for niche errors, or add excessive workarounds. So: let's do
the easy thing and increase rustls-ffi's MSRV to 1.73. The rustls-ffi
project has few downstream consumers at this point and so is more agile
for MSRV bumps than the core crate.

Along the way, match the formatter to the MSRV. It had fallen behind.
  • Loading branch information
cpu committed Dec 12, 2024
1 parent de80a96 commit ce84ad7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- nightly
# MSRV - keep in sync with what rustls and rustls-platform-verifier
# consider MSRV
- "1.71"
- "1.73"
os: [ ubuntu-latest ]
# Include a few MacOS and cert-compression builds to ensure they're tested without
# bloating the matrix or slowing down CI.
Expand Down Expand Up @@ -310,7 +310,7 @@ jobs:
- name: Install rust toolchain
uses: dtolnay/rust-toolchain@master
with:
toolchain: "1.71"
toolchain: "1.73" # Matching MSRV
components: rustfmt

- name: Install Gersemi
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ to provide the cryptographic primitives.
# Build rustls-ffi

To build rustls-ffi as a static or shared library you'll need to [install the
Rust toolchain](https://rustup.rs/) (version 1.71 or above) as well as
Rust toolchain](https://rustup.rs/) (version 1.73 or above) as well as
[cargo-c].

The [cargo-c] tool can be installed from
Expand Down

0 comments on commit ce84ad7

Please sign in to comment.