Skip to content

Commit

Permalink
tests: wait for tcp port for all test types.
Browse files Browse the repository at this point in the history
The `run_mtls_client_tests` and `run_mtls_client_crl_tests` were being
run without calling `wait_tcp_port` first. I suspect this is the reason
we sometimes see the connect tests fail in CI on some platforms with
output about the connection being refused.
  • Loading branch information
cpu committed Aug 16, 2023
1 parent 6f9bcf5 commit 40ea994
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/client-server.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ def main():
server_popen = run_server(server, valgrind, {
"AUTH_CERT": "testdata/minica.pem",
})
wait_tcp_port(HOST, PORT)
run_mtls_client_tests(client, valgrind)
server_popen.kill()
server_popen.wait()
Expand All @@ -228,6 +229,7 @@ def main():
"AUTH_CERT": "testdata/minica.pem",
"AUTH_CRL": "testdata/test.crl.pem",
})
wait_tcp_port(HOST, PORT)
run_mtls_client_crl_tests(client, valgrind)


Expand Down

0 comments on commit 40ea994

Please sign in to comment.