Skip to content

Commit

Permalink
ci: test windows dyn link
Browse files Browse the repository at this point in the history
This requires an upstream bug-fix from cargo-c. To support dynamic
linking on windows ensure you are using cargo-c 0.10.7+.

With this in place, we can run integration tests against client/server
binaries that dynamically link librustls.dll \o/
  • Loading branch information
cpu committed Nov 29, 2024
1 parent 3b0b18e commit 116aaf3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,9 @@ jobs:
dyn_link: [ off ]
include:
# One build with dynamic linking.
# TODO(@cpu): debug broken dyn-link build on Windows.
# - crypto: aws-lc-rs
# config: Release
# dyn_link: on
- crypto: aws-lc-rs
config: Release
dyn_link: on
# One build with cert_compression.
- crypto: aws-lc-rs
config: Release
Expand All @@ -221,6 +220,7 @@ jobs:
with:
arch: x64

# Note: must use cargo-c 0.10.7+ for dynamic linking support on Windows.
- name: Install cargo-c
env:
LINK: https://github.com/lu-zero/cargo-c/releases/latest/download
Expand Down

0 comments on commit 116aaf3

Please sign in to comment.