Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI and badges #4

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Added CI and badges #4

merged 1 commit into from
Dec 6, 2024

Conversation

ancwrd1
Copy link
Collaborator

@ancwrd1 ancwrd1 commented Dec 6, 2024

That fixes #3

@ancwrd1 ancwrd1 merged commit 7993f1d into dev Dec 6, 2024
4 checks passed
@cpu
Copy link
Member

cpu commented Dec 6, 2024

Thanks! Here's a quick follow-up tweak (#5) like ones I've been landing elsewhere (rustls/tokio-rustls#96, rustls/rustls-platform-verifier#154, etc)

@ancwrd1
Copy link
Collaborator Author

ancwrd1 commented Dec 6, 2024

While I have your attention here :)
Any hint to how fix docs.rs?
https://docs.rs/crate/rustls-cng/0.5.1/builds/1389786

@cpu
Copy link
Member

cpu commented Dec 6, 2024

Any hint to how fix docs.rs?

Hmmm. I know we've had trouble with docs.rs and aws-lc-rs w/ FIPS mode enabled in the past (c.f. rustls/rustls#1827) but I see you're already configuring just the ring feature here:

features = ["ring"]

I wonder if it's a similar problem but with respect to the explicit x86_64-pc-windows-gnu target in your docs.rs config requiring extra tools for aws-lc-sys to build that aren't present on the host. I'm still not sure why it would matter given you disabled default features on rustls and build with only ring enabled 🤔

@ctz Does the build error trace ring any bells for you?

@ancwrd1
Copy link
Collaborator Author

ancwrd1 commented Dec 6, 2024

I just added it today to the manifest file in a naive attempt to fix it, but I am not sure it will work and I don't want to publish a new release just to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding CI?
2 participants