Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 0.9.0-beta.0 #1535

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Prepare 0.9.0-beta.0 #1535

wants to merge 7 commits into from

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Nov 23, 2024

  • Added a CHANGELOG.md entry

Prepare the beta release.

Blocker: #1530 (awaiting review).

@dhardy dhardy mentioned this pull request Nov 23, 2024
Open
23 tasks
newpavlov
newpavlov approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's also worth to cut a pre-release for getrandom? I wanted for @josephlr to take a look at the crate before that, but unfortunately, it does not look like he will be able to do it in the near term.

@dhardy
Copy link
Member Author

dhardy commented Nov 24, 2024

IIRC the only places getrandom is exposed in the API are the associated Error type of TryRngCore for OsRng and the pub use getrandom in rand_core. So, yes, it might make sense — though it might make even more sense to hide the exact getrandom version from the pub API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov newpavlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhardy @newpavlov