Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zerocopy 0.7.33, not 0.8.0-alpha #1446

Merged
merged 1 commit into from
May 7, 2024

Conversation

joshlf
Copy link
Contributor

@joshlf joshlf commented May 4, 2024

Trying this to see if we can unblock #1165.

@joshlf
Copy link
Contributor Author

joshlf commented May 4, 2024

Looks like the failures are nightly-only, and I suspect just zerocopy needing to update based on changes to the stdsimd nightly feature, which is orthogonal to the question of unblocking #1165.

@joshlf
Copy link
Contributor Author

joshlf commented May 4, 2024

Ah, maybe even simpler: I just need to backport this change to 0.7: https://github.com/google/zerocopy/pull/846/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759

@joshlf joshlf mentioned this pull request May 4, 2024
23 tasks
@joshlf joshlf changed the title Use zerocopy 0.7.32, not 0.8.0-alpha Use zerocopy 0.7.33, not 0.8.0-alpha May 4, 2024
@dhardy dhardy requested a review from josephlr May 5, 2024 07:18
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for patching 0.7 to fix this!

@josephlr josephlr merged commit 1f81878 into rust-random:master May 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants