Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustc-dep-of-std feature #78

Merged
merged 4 commits into from
Aug 6, 2019
Merged

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Aug 5, 2019

This is how libc and hashbrown support being dependancies of libstd.
This allows getrandom to use core normally, and use the sysroot core
when building libstd.

This PR and #58 should be enough to get rust-lang/rust#62082 building without errors.

This is how `libc` and `hashbrown` support being dependancies of `libstd`.
This allows `getrandom` to use `core` normally, and use the sysroot `core`
when building `libstd`.
@newpavlov
Copy link
Member

newpavlov commented Aug 5, 2019

You probably also should remove uses of --all-features from CI tests.

I am not familiar with the details of how std is built, so I hope someone more knowledgeable will confirm, that it's indeed a correct approach in our case.

cc @alexcrichton

@josephlr
Copy link
Member Author

josephlr commented Aug 5, 2019

You probably also should remove uses of --all-features from CI tests.

Done

I am not familiar with the details of how std is build, so I hope someone more knowledgeable will confirm, that it's indeed a correct approach in our case.

I know we need at least this to properly use the core and compiler_builtins libraries in the sysroot. We may also need additional functionality, I'm not sure.

@alexcrichton
Copy link
Collaborator

I can confirm that for building as part of the standard library the Cargo.toml bits are correct and would be required.

.travis.yml Outdated Show resolved Hide resolved
@josephlr
Copy link
Member Author

josephlr commented Aug 6, 2019

This should be ready for merging, I updated the Redox comment to better explain the issue in #79.

I also confirmed that this PR + #58 + a modified version of @newpavlov's rust-lang/rust#62082 is now enough to bootstrap libstd without errors.

EDIT: I should also note that this does not depend on #58

@newpavlov newpavlov merged commit 98934cb into rust-random:master Aug 6, 2019
@josephlr josephlr deleted the libstd branch August 7, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants