netbsd: fix fallback and test it using configuration flag #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh... It looks our NetBSD fallback code was incorrect. Surprisingly, the bug was not reported for all this time, so I guess virtually no one uses Rust on older NetBSDs. |
newpavlov
changed the title
newpavlov
force-pushed
the
netbsd_fallback
branch
from
98ea48f to
77968ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in the NetBSD fallback code based on
KERN_ARND.sysctlreturns either 0 or -1, while the code assumed that on success it returns number of bytes filled.Adds the
getrandom_test_netbsd_fallbackconfiguration flag, which forces the NetBSD backend to use theKERN_ARNDfallback, and tweaks CI to use the flag.Closes #289