Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove impl From<NonZeroU32> for Error and Error::code #507

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Remove impl From<NonZeroU32> for Error and Error::code #507

merged 5 commits into from
Oct 9, 2024

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Oct 7, 2024 •
edited
Loading

Also adds Error::{new_custom, new_internal} methods and changes return type of __getrandom_custom to Result<(), getrandom::Error>.

Closes #455

@newpavlov newpavlov requested a review from josephlr October 7, 2024 15:15
@newpavlov newpavlov merged commit 387248f into master Oct 9, 2024
52 checks passed
@newpavlov newpavlov deleted the rm_error_from branch October 9, 2024 13:06
@dhardy dhardy mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr Awaiting requested review from josephlr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate and remove impl From<NonZeroU32> for Error.
1 participant
@newpavlov