-
Notifications
You must be signed in to change notification settings - Fork 190
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use libc::getrandom on Solaris and update docs.
#417 used `getentropy(2)` on Solaris, but after looking at [the blog post introducing `getrandom()` and `getentropy()`](https://blogs.oracle.com/solaris/post/solaris-new-system-calls-getentropy2-and-getrandom2), it seems like we should prefer using `getrandom` based on this quote: > On Solaris the output of getentropy(2) is entropy and should not be used where randomness is needed, in particular it must not be used where an IV or nonce is needed when calling a cryptographic operation. It is intended only for seeding a user space RBG (Random Bit Generator) system. More specifically the data returned by getentropy(2) has not had the required FIPS 140-2 processing for the DRBG applied to it. I also updated some of the documentation explaining: - Why we ever use `getentropy(2)` - Why we don't ever set `GRND_RANDOM` Signed-off-by: Joe Richey <[email protected]>
- Loading branch information
Showing
3 changed files
with
30 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,38 @@ | ||
| //! Implementation using `libc::getrandom`. | ||
| //! Implementation using getrandom(2). | ||
| //! | ||
| //! Available since: | ||
| //! - Linux Kernel 3.17, Glibc 2.25, Musl 1.1.20 | ||
| //! - Android API level 23 (Marshmallow) | ||
| //! - NetBSD 10.0 | ||
| //! - FreeBSD 12.0 | ||
| //! - Solaris 11.3 | ||
| //! - Illumos since Dec 2018 | ||
| //! - illumos since Dec 2018 | ||
| //! - DragonFly 5.7 | ||
| //! - Hurd Glibc 2.31 | ||
| //! - shim-3ds since Feb 2022 | ||
| //! | ||
| //! For all platforms, we always use the default entropy pool and never set the | ||
| //! GRND_RANDOM flag to use the /dev/random pool. On Linux/Android/Hurd, using | ||
| //! GRND_RANDOM is not recommended. On NetBSD/FreeBSD/Dragonfly/3ds, it does | ||
| //! nothing. On illumos, the default pool is used to implement getentropy(2), | ||
| //! so we assume it is acceptable here. On Solaris, the story is less clear, | ||
| //! but both pools use standard DRBGs (FIPS 140-2 and NIST SP-900-90A), so we | ||
| //! use the default pool. For more information on Solaris see this blog post: | ||
| //! https://blogs.oracle.com/solaris/post/solaris-new-system-calls-getentropy2-and-getrandom2 | ||
| use crate::{util_libc::sys_fill_exact, Error}; | ||
| use core::mem::MaybeUninit; | ||
|
|
||
| // On Solaris 11.3, if bufsz > 1024 (> 133120 on Solaris 11.4) calls to | ||
| // getrandom(2) will always fail, so we chunk the buffer if it is too long. | ||
| #[cfg(target_os = "solaris")] | ||
| const MAX_BYTES: usize = 1024; | ||
| #[cfg(not(target_os = "solaris"))] | ||
| const MAX_BYTES: usize = usize::MAX; | ||
|
|
||
| pub fn getrandom_inner(dest: &mut [MaybeUninit<u8>]) -> Result<(), Error> { | ||
| sys_fill_exact(dest, |buf| unsafe { | ||
| libc::getrandom(buf.as_mut_ptr() as *mut libc::c_void, buf.len(), 0) | ||
| }) | ||
| for chunk in dest.chunks_mut(MAX_BYTES) { | ||
| sys_fill_exact(dest, |buf| unsafe { | ||
| libc::getrandom(buf.as_mut_ptr() as *mut libc::c_void, buf.len(), 0) | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters