Clarify example for trait method float::Float::integer_decode
#326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#126610
Problem
The example for trait method float::Float::integer_decode fails if
num
is changed to most any value other than 2.Changes
The equation used to recover the original number,
num
, from the outputs ofFloat::integer_decode(num)
is given in the doc comment assign * mantissa * 2 ^ exponent
. However, in the example,num
was being used as the exponent's base, as in the equationsign * mantissa * num ^ exponent
. This PR fixes that mistake.It follows logically that when
num
is 2, the example behaves correctly even with the bug. To reduce confusion, this PR changes the value ofnum
in the example to be 42.For readability, this PR also moves the invocation of
.powf(exponent as f32)
, so it is directly underneath the comment// 1 * 11010048 * 2^(-18) == 42
.Updated example