book:just configs #661
Closed
book:just configs #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
book:clean install and serve in 1 minute nostr-rs-book.480.mov |
RandyMcMillan
force-pushed
the
1985/872668/752821/358b43c0/d33a7b48-book-just-configs
branch
2 times, most recently
from
310d537 to
cd03183
Compare
yukibtc
requested changes
Dec 1, 2024
book/justfile
Outdated
Comment on lines
31
to
34
| rm -rf $(which mdbook) | ||
| rm -rf $(which mdbook-linkcheck) | ||
| rm -rf $(which mdbook-admonish) | ||
| rm -rf $(which mdbook-snippets) |
There was a problem hiding this comment.
Here I would use cargo uninstall, so will work on every OS.
book/snippets/rust/Cargo.toml
Outdated
Comment on lines
11
to
12
| nostr-sdk = { version = "*", features = ["all-nips"] } | ||
| nostr-relay-builder = "*" |
There was a problem hiding this comment.
The version here must match the version in the book docs, so 0.37.
justfile
Outdated
| @@ -64,7 +68,7 @@ clean: | |||
|
|
|||
| # Build and serve the book | |||
| book: | |||
| cd book && just serve | |||
| cd book && just build serve | |||
There was a problem hiding this comment.
There is no need to call build command when serving. The book is automatically built when running mdbook serve.
justfile
Outdated
Comment on lines
48
to
51
| # Build nostr examples | ||
| examples: | ||
| cargo build --examples --release | ||
|
|
There was a problem hiding this comment.
I think that who want to run an example, build and run only the one is interested in, so this command IMO is not really needed.
|
thanks for the feedback - I will follow up soon. |
RandyMcMillan
force-pushed
the
1985/872668/752821/358b43c0/d33a7b48-book-just-configs
branch
from
9746f0a to
9897df9
Compare
|
|
Thanks, cherry-picked and squashed at 219556e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.