Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(relay): optimize relay connection handling #635

Closed
wants to merge 1 commit into from

Conversation

kasugamirai
Copy link
Contributor

@kasugamirai kasugamirai commented Nov 17, 2024

Description

Notes to the reviewers

Checklist

Copy link
Member

@yukibtc yukibtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but IMO this change make the code less readable without bringing a real improvement: the add_relay method internally just acquire a write lock and update an HashMap. This approach is good in other situations (I used it in other part of code).

@yukibtc yukibtc closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants