book: add NIP21 JavaScript examples #590
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Wasn’t able to adde the full URI examples for
note
andnpub
, figured it was related to the JS bindings not havingtoNostrUri()
method exposed currently. If you’re able to add this let me know and I’ll update the examples.Similarly, consider adding
fromNostrUri()
to the theCoordinate
class and I’ll tweak the current Bech32 example so that it show how to decode the URI.Finally, I noticed the
NIP21
withparse()
method wasn’t available for the js bindings, as with python. Was this intentional or is it a limitation of the js binding themselves?Checklist
just precommit
orjust check
before committing