nostr: change Timestamp::to_human_datetime fingerprint

Return a `String` instead of `Cow<str>`.

Closes #622

Signed-off-by: Yuki Kishimoto <[email protected]>

CHANGELOG.md

@@ -29,6 +29,7 @@
 
 * nostr: change `EventBuilder::gift_wrap` (and linked methods) args to take `extra_tags` instead of `expiration` ([erskingardner])
 * nostr: disable all default features except `std` ([Yuki Kishimoto])
+* nostr: change `Timestamp::to_human_datetime` fingerprint ([Yuki Kishimoto])
 * pool: switch from async to sync message sending for `Relay` ([Yuki Kishimoto])
 * sdk: disable all default features ([Yuki Kishimoto])
 * sdk: set `Client::from_builder` as private ([Yuki Kishimoto])

bindings/nostr-sdk-ffi/src/protocol/types/time.rs

@@ -50,6 +50,6 @@ impl Timestamp {
 
     /// Convert [`Timestamp`] to human datetime
     pub fn to_human_datetime(&self) -> String {
-        self.inner.to_human_datetime().into_owned()
+        self.inner.to_human_datetime()
     }
 }

bindings/nostr-sdk-js/src/protocol/types/time.rs

@@ -53,6 +53,6 @@ impl JsTimestamp {
     /// Convert `Timestamp` to human datetime
     #[wasm_bindgen(js_name = toHumanDatetime)]
     pub fn to_human_datetime(&self) -> String {
-        self.inner.to_human_datetime().into_owned()
+        self.inner.to_human_datetime()
     }
 }

crates/nostr/src/types/time/mod.rs

@@ -4,8 +4,7 @@
 
 //! Time
 
-use alloc::borrow::Cow;
-use alloc::string::ToString;
+use alloc::string::{String, ToString};
 use core::fmt;
 use core::ops::{Add, Range, Sub};
 use core::str::{self, FromStr};
@@ -134,12 +133,12 @@ impl Timestamp {
     }
 
     /// Convert [`Timestamp`] to human datetime
-    pub fn to_human_datetime<'a>(&self) -> Cow<'a, str> {
+    pub fn to_human_datetime(&self) -> String {
         let timestamp: u64 = self.as_u64();
 
         if timestamp >= 253_402_300_800 {
             // Year 9999
-            return Cow::Borrowed("Unavailable");
+            return String::from("Unavailable");
         }
 
         let days = (timestamp / 86400) as i64 - LEAPOCH;
@@ -207,7 +206,7 @@ impl Timestamp {
         buf[17] = b'0' + (secs_of_day / 10 % 6) as u8;
         buf[18] = b'0' + (secs_of_day % 10) as u8;
 
-        Cow::Owned(str::from_utf8(&buf).unwrap_or_default().to_string())
+        str::from_utf8(&buf).unwrap_or_default().to_string()
     }
 }
 
@@ -294,7 +293,7 @@ mod tests {
         let timestamp = Timestamp::from(1682060685);
         assert_eq!(
             timestamp.to_human_datetime(),
-            Cow::from("2023-04-21T07:04:45Z")
+            String::from("2023-04-21T07:04:45Z")
         );
     }
 }