Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MCP concern syntax hint #1863

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Dec 4, 2024

Fixing a typo when suggesting the syntax to raise concerns on compiler MCPs (template was implemented in #1747)

@ehuss
Copy link
Contributor

ehuss commented Dec 4, 2024

Does rfcbot just ignore these commands because it is not enabled on the repo?

What happens if you do @rustbot concern on it?

@apiraino
Copy link
Contributor Author

apiraino commented Dec 5, 2024

Does rfcbot just ignore these commands because it is not enabled on the repo?

What happens if you do @rustbot concern on it?

Basically a no-op (see comment)

@ehuss
Copy link
Contributor

ehuss commented Dec 5, 2024

I'm confused. The link to that comment uses @rustbot. Nothing in that PR seems to mention rfcbot.
Does rfcbot also ignore it?
Do you want to change this just to be more consistent with the use of rfcbot in other repositories?

@apiraino
Copy link
Contributor Author

apiraino commented Dec 5, 2024

@rfcbot concern this-is-a-test

@apiraino
Copy link
Contributor Author

apiraino commented Dec 5, 2024

Ok, no user-visible effects. But the logic in the triagebot to gather concerns needs the @rfcbot invocation, just as I had implemented it since the beginning

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see, thanks!

@ehuss ehuss merged commit 1300896 into rust-lang:master Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants