Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend automatic rendered link to the blog.rust-lang.org repo #1839

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Sep 6, 2024

This PR extends the automatic addition of the "Rendered" link to the blog.rust-lang.org repo, as is currently done for the rfcs repo.

@Urgau Urgau force-pushed the rendered_link-blog branch from f874681 to ff80464 Compare September 6, 2024 22:07
@apiraino
Copy link
Contributor

apiraino commented Sep 9, 2024

Maybe it's me but I don't understand what this patch is doing (I feel it's doing something useful). Can you please provide an example? 🙂

@Urgau
Copy link
Member Author

Urgau commented Sep 9, 2024

Sure, currently when opening a PR on the rust-lang/rfcs repo, triagebot will append to the PR description a link to directly see the rendered RFC without having to manually add it (for PR author) and manually find it (by looking at the modified files and clicking on view file).

An example can be found on rust-lang/rfcs#3683 (comment), where it can be seen that rustbot/triagebot modified the PR description to add that rendered link. Such example can be found on all RFCs PR.

This PR just modifies the triggering logic to also apply this useful logic to the blog repo.

@apiraino
Copy link
Contributor

apiraino commented Sep 9, 2024

Ah OK, so the blog posts PRs will automatically have the markdown rendered link in the opening comment instead of the user having to click around and find it themself.

Cool, thanks.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm a little on the fence with how useful this is. There are also some drawbacks (like these links will often be broken after merging). However, I don't think it should cause too much harm, and we can easily revert this if people have problems with it.

@ehuss ehuss merged commit 31ab10c into rust-lang:master Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants