Add more logging for unexpected status codes. #1817
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more logging in the saga to determine why diffing is not working as expected. For the cargo milestoning, all I see in the logs is:
and then nothing. My theory is that it is returning some unexpected status code. The retry logic checks for
!is_success()
which only checks for codes 2xx, and then error reporting code only checks forerror_for_status_ref
, which is only 4xx and 5xx. My guess is that some other status code is slipping through? I'm really shooting in the dark since I can't reproduce the issue locally.