-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ARM intrinsic generator #1693
base: master
Are you sure you want to change the base?
New ARM intrinsic generator #1693
Conversation
Co-authored-by: Jamie Cunliffe <[email protected]> Co-authored-by: Jacob Bramley <[email protected]> Co-authored-by: Luca Vizzarro <[email protected]>
Co-authored-by: Jamie Cunliffe <[email protected]> Co-authored-by: Jacob Bramley <[email protected]> Co-authored-by: Luca Vizzarro <[email protected]>
c48b138
to
00d6c50
Compare
Some initial notes (I'm travelling and will do a full review later):
|
Thanks, hope your travels are going smoothly! It can be a pretty hectic time of year. I'll hold off changes until you've had a more thorough perusal. With respect to the intrinsics floating about in the example you gave of This is based off it being time consuming porting the old intrinsics over coupled with the desire to unblock other units of work that cannot be achieved without the new generator. I do, however, undoubtedly agree that the goal should be to have all of these intrinsics generated with the new generator. |
Thanks for your review, I believe the latest commit should have taken care of your comments. |
New Arm intrinsic generator
A new generator for creating ARM intrinsics using YAML. The input which superseeds the old generators bespoke file format that was proving cumbersome to maintain and tricky to expand to support other architectures than neon. The YAML provides a more expressive and maintainable way to declare intrinsics.
Summary of changes
aarch64/neon/generated.rs
andarm_shared/neon/generated.rs
are both newly created from the new input as such has a slightly different output and code style.