-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some SSE and SSE2 tests for Miri #1472
Conversation
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
Can you rebase to fix CI? |
Like done in `test_mm_rcp_ps`, but only for the first element.
This overflow was found while testing core_arch with miri
It uses the syn crate to parse the function, so the name can now be extracted without the `find_name` helper.
Why did this start failing now?
|
This is probably because something changed in the latest rustc nightly. Hopefully it will get noticed and reverted soon, but otherwise this should be fairly easy to fix. |
It think I figured it out. It is not a change in rustc. It is the change to |
We are adding stdarch to libstd Miri testing (rust-lang/miri-test-libstd#19).
Some tests required some fixing, while there are other that are simply ignored because it is unlikely that Miri support them in the near future.
For now, only SSE and SSE2 are being considered.
cc @RalfJung