Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/rustup-mode): remove .num_args() when .value_delimiter(',') is present #4076

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix(cli/rustup-mode): remove .num_args() when .value_delimiter(',') is present #4076

merged 2 commits into from
Nov 13, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Nov 13, 2024

Closes #4073, as discussed in #4073 (comment).

@rami3l rami3l requested a review from djc November 13, 2024 13:06
djc
djc approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rami3l rami3l enabled auto-merge November 13, 2024 13:18
@rami3l rami3l added this pull request to the merge queue Nov 13, 2024
Merged via the queue into rust-lang:master with commit c8eddcb Nov 13, 2024
27 checks passed
@rami3l rami3l deleted the fix/comma-sep branch November 13, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot install toolchain if preceding option uses comma separated list as an argument
2 participants
@rami3l @djc