Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist: bump rustup version to 1.28.0 #4041

Closed
wants to merge 6 commits into from
+63 −11
Closed

dist: bump rustup version to 1.28.0 #4041

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89bd6ed
build: use `workspace.package` properties in `Cargo.toml`
rami3l Oct 6, 2024
ef1beca
dist: bump `rustup` version to `1.28.0`
rami3l Oct 6, 2024
c74c8f2
docs: (wip) update `CHANGELOG` for `1.28.0`
rami3l Oct 6, 2024
2c364c7
fixup! docs: (wip) update `CHANGELOG` for `1.28.0`
rami3l Oct 6, 2024
079d29e
fixup! fixup! docs: (wip) update `CHANGELOG` for `1.28.0`
rami3l Oct 6, 2024
15ba87a
fixup! fixup! fixup! docs: (wip) update `CHANGELOG` for `1.28.0`
rami3l Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ regex = "1"
members = ["download"]

[workspace.package]
version = "1.27.1"
version = "1.28.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you previously suggested calling this 2.0 on Discord.

I'm wondering if we should use Rustup v2.0.0 instead of v1.28.0. The changes since this May have been dramatic and, maybe this way we can better communicate the breakage regarding #3635.

I said:

Yeah, might make sense

@rbtcollins said:

I have no objection. We have not done strict semver thus far

Here you're updating to 1.28.0 instead of 2.0.0, so has your thinking changed?

edition = "2021"
license = "MIT OR Apache-2.0"

Expand Down
Loading