Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli)!: remove implicit toolchain installation #3985

Merged
merged 10 commits into from
Aug 9, 2024
Prev Previous commit
Next Next commit
refactor(config)!: make resolve_toolchain() sync
rami3l committed Aug 9, 2024
commit b066dde7feea176d00819113b8b299a861671d7d
2 changes: 1 addition & 1 deletion src/cli/rustup_mode.rs
Original file line number Diff line number Diff line change
@@ -908,7 +908,7 @@ async fn which(
binary: &str,
toolchain: Option<ResolvableToolchainName>,
) -> Result<utils::ExitCode> {
let binary_path = cfg.resolve_toolchain(toolchain).await?.binary_file(binary);
let binary_path = cfg.resolve_toolchain(toolchain)?.binary_file(binary);

utils::assert_is_file(&binary_path)?;

2 changes: 1 addition & 1 deletion src/config.rs
Original file line number Diff line number Diff line change
@@ -709,7 +709,7 @@ impl<'a> Cfg<'a> {
Ok(Some(Toolchain::new(self, name)?.rustc_version()))
}

pub(crate) async fn resolve_toolchain(
pub(crate) fn resolve_toolchain(
&self,
name: Option<ResolvableToolchainName>,
) -> Result<Toolchain<'_>> {