Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication for show commands #3813

Merged
merged 4 commits into from
May 7, 2024
Merged

Reduce code duplication for show commands #3813

merged 4 commits into from
May 7, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented May 7, 2024 •
edited
Loading

This stuck out at me during my review of #3596.

@djc djc requested a review from rami3l May 7, 2024 11:59
@rami3l
Copy link
Member

rami3l commented May 7, 2024 •
edited
Loading

@djc Thanks! I remember I wanted to do this after #3637 (where I introduced .components()), but I somehow forgot it 🤣

rami3l
rami3l approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@djc djc added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit 9caf4fc May 7, 2024
22 checks passed
@djc djc deleted the merge branch May 7, 2024 15:51
@rami3l rami3l mentioned this pull request Oct 6, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @rami3l