New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): use `github.event_name == 'push'` instead of `github.event.push` #3627

Merged

rami3l merged 1 commit into master from fix/ci-push-pred

Jan 4, 2024

Member

rami3l commented Jan 4, 2024

Tries to address the concern in #3582 (comment).

github.event.push is the suspect here since:

... it triggers Context access might be invalid warnings in VSCode;
github.event_name == 'push' seem to work elsewhere in ci.yaml.


          fix(ci): use github.event_name == 'push' instead of `github.event.p…

…ush`

djc approved these changes

View reviewed changes

rami3l merged commit 578696b into master

21 checks passed

rami3l deleted the fix/ci-push-pred branch

January 4, 2024 17:19

rami3l mentioned this pull request

Meta: Consider introducing GitHub Merge Queue to the repo #3567

Closed

3 tasks

rami3l mentioned this pull request

dist: bump rustup version to 1.27.0 #3653

Merged

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet