Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document automatic installation behavior via rustup show #2797

Merged
merged 2 commits into from
Jul 17, 2021

Conversation

Rustin170506
Copy link
Member

close #2639

@rbtcollins
Copy link
Contributor

I'm torn on this - I haven't even read the patch yet, but see #2686 and #1397

This patch is documenting things we consider bugs. It is good to have the current behaviour documented, OTOH then folk may remember what they read and not-re-read the docs after we fix those bugs. perhaps a note to the effect that this is under review or something, and a link to the bugs?

@Rustin170506
Copy link
Member Author

perhaps a note to the effect that this is under review or something, and a link to the bugs?

Add a note for it. Thanks for the review, I didn't notice that it was considered a bug. 🤣

@Rustin170506
Copy link
Member Author

Also, I'm not sure that if it's considered a bug, then we should still document it. Because @kinnison his original idea was to let people know about the behavior and use it in CI. But if it is a bug, will it have a big impact on users when it is fixed?

@rbtcollins
Copy link
Contributor

yeah, CI users will use 'rustup ensure' or whatever verb we end up on.'

@Rustin170506
Copy link
Member Author

@rbtcollins @kinnison Should I close the PR or is this clarification acceptable for now? (I don't currently recommend it in the description for use in CI)

@kinnison kinnison merged commit 626b7a8 into rust-lang:master Jul 17, 2021
@Rustin170506 Rustin170506 deleted the rustin-patch-docs-show branch July 18, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document autoinstallation behaviour on overrides page of docs
3 participants