Replace Config
field 5-tuple with a struct
#6334
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
struct ConfigOption<T>
to replace the 5-element tuple used forConfig
fields, to make the code more readable.The tuple element 3 is actually
true
if the option is stable, the opposite of what the comment said.Also changes
IgnoreList::doc_hint
to return"[<string>, ...]"
instead of"[<string>,..]"
. It is now the same syntax asMacroSelectors::doc_hint
.