Use DLL_EXTENSION rather than hardcoding .so
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-Linux platforms should be able to build the backend, but MacOS can't find the shared library because the extension is incorrect. Use `DLL_EXTENSION` rather than a fixed `.so`.
tgross35
force-pushed
the
use-dll-extension
branch
from
fde81c7 to
8b60471
Compare
|
With this change, tests pass on MacOS. |
|
This won't work with cross-compilation. You did need something like https://github.com/rust-lang/rustc_codegen_cranelift/blob/616abf15d9690d29fa62abbfe70c4139b85f4c50/build_system/rustc_info.rs#L80-L99 instead for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-Linux platforms should be able to build the backend, but MacOS can't find the shared library because the extension is incorrect. Use
DLL_EXTENSIONrather than a fixed.so.