Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup bootstrap and ci #3

Merged
merged 9 commits into from
Sep 25, 2024
Merged

feat: setup bootstrap and ci #3

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c19d4b7
feat: setup bootstrap and ci
Wybxc Sep 19, 2024
719d2aa
chore: remove useless Path::new
Wybxc Sep 20, 2024
28e2411
chore: endline
Wybxc Sep 20, 2024
9ab2c93
fix: panic on clean
Wybxc Sep 20, 2024
0842a73
fix: status check of fmt
Wybxc Sep 20, 2024
d962aab
feat: prefer new version of FileCheck
Wybxc Sep 24, 2024
3d02864
chore: rename `debug` to `verbose`
Wybxc Sep 25, 2024
01efce2
chore: fix newline at eof
Wybxc Sep 25, 2024
c489f1e
chore: unify subcommand interface
Wybxc Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,52 +12,51 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Install Rust
run: |
rustup update nightly --no-self-update
rustup default nightly
rustup component add clippy
run: rustup show
Wybxc marked this conversation as resolved.
Show resolved Hide resolved
- uses: Swatinem/rust-cache@v2
# FIXME: enable once there is code
# - run: cargo clippy --all-features --all-targets -- -D warnings
- name: Install packages
run: |
sudo apt-get install llvm-14-tools
- run: cargo clippy --manifest-path crates/Cargo.toml --all-features --all-targets -- -D warnings

test:
name: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install Rust
run: |
rustup update nightly --no-self-update
rustup default nightly
rustup component add clippy
run: rustup show
- uses: Swatinem/rust-cache@v2
# FIXME: enable once there is code
# - run: cargo test
- name: Install packages
run: |
sudo apt-get install llvm-14-tools
- run: ./y test

rustfmt:
name: rustfmt
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v4
- name: Install Rust
run: rustup show
- uses: Swatinem/rust-cache@v2
- name: Install packages
run: |
rustup update nightly --no-self-update
rustup default nightly
rustup component add rustfmt
# FIXME: enable once there is code
# - run: cargo fmt --all -- --check
sudo apt-get install llvm-14-tools
- run: ./y fmt --check

doc:
name: docs
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: |
rustup update nightly --no-self-update
rustup default nightly
- name: Install Rust
run: rustup show
- uses: Swatinem/rust-cache@v2
# FIXME: enable once there is code
# - run: cargo doc
- name: Install packages
run: |
sudo apt-get install llvm-14-tools
- run: cargo doc --manifest-path crates/Cargo.toml

success:
needs:
Expand All @@ -73,4 +72,4 @@ jobs:
steps:
# Manually check the status of all dependencies. `if: failure()` does not work.
- name: check if any dependency failed
run: jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'
run: jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/build
rustc-ice-*
8 changes: 8 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"rust-analyzer.rustc.source": "discover",
"rust-analyzer.workspace.symbol.search.scope": "workspace_and_dependencies",
"rust-analyzer.linkedProjects": [
"./crates/Cargo.toml",
"./bootstrap/Cargo.toml",
]
}
1 change: 1 addition & 0 deletions bootstrap/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/target
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you make sure the files have trailing newlines because I think some Unix tools assume trailing newlines exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the GH UI, these are still missing. Just look at the diff view and make sure none of the files have that symbol.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu did you mean to mark this as resolved? Looks like they are still there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, or maybe you had it resolved before and I just commented without unresolving :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh maybe I thought they were fixed, not sure

Loading