Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Don't emit debuginfo for backtrace deps #74591

Conversation

alexcrichton
Copy link
Member

This was evaluated in #74560 and shown to have a positive effect on some
of the regressions originally reported from #73441. While it doesn't
recover all of the lost ground this is hopefully an easy enough knob to
tweak that we don't have worry too much about it later.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2020
@jonas-schievink
Copy link
Contributor

@bors rollup=never

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2020

📌 Commit 8a80a3eae7d0aa2f063d3effca4344edf9e73fdc has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2020
Cargo.toml Outdated
Comment on lines 63 to 72
[profile.release.package.miniz_oxide]
debug = 0
[profile.release.package.gimli]
debug = 0
[profile.release.package.addr2line]
debug = 0
[profile.release.package.object]
debug = 0
[profile.release.package.adler]
debug = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it more dense?

Suggested change
[profile.release.package.miniz_oxide]
debug = 0
[profile.release.package.gimli]
debug = 0
[profile.release.package.addr2line]
debug = 0
[profile.release.package.object]
debug = 0
[profile.release.package.adler]
debug = 0
[profile.release.package]
miniz_oxide = { debug = 0 }
gimli = { debug = 0 }
addr2line = { debug = 0 }
object = { debug = 0 }
adler = { debug = 0 }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems really unnecessary.

Copy link
Member

@eddyb eddyb Jul 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, does TOML have the Nix thing of letting you write gimli = { debug = 0 } as gimli.debug = 0? IMO using the dot notation would feel more natural, but then again maybe that's personal bias.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes TOML supports gimli.debug = 0, so I've gone ahead and updated to use that.

This was evaluated in rust-lang#74560 and shown to have a positive effect on some
of the regressions originally reported from rust-lang#73441. While it doesn't
recover all of the lost ground this is hopefully an easy enough knob to
tweak that we don't have worry too much about it later.
@alexcrichton alexcrichton force-pushed the backtrace-deps-no-debuginfo branch from 8a80a3e to 3075cc3 Compare July 21, 2020 22:41
@alexcrichton
Copy link
Member Author

@bors: r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 21, 2020

📌 Commit 3075cc3 has been approved by Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r-

We've discussed a bit and we want to revert the (original) backtrace PR and re-land it in the next week or so, but after getting a try build that fully evaluates it plus this patch (amongst others, perhaps) to better gauge the effects on perf.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2020
@Mark-Simulacrum Mark-Simulacrum added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2020
@alexcrichton
Copy link
Member Author

Ok, then let's close this.

@alexcrichton alexcrichton deleted the backtrace-deps-no-debuginfo branch July 22, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants