-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Don't emit debuginfo for backtrace deps #74591
std: Don't emit debuginfo for backtrace deps #74591
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors rollup=never |
@bors r+ |
📌 Commit 8a80a3eae7d0aa2f063d3effca4344edf9e73fdc has been approved by |
Cargo.toml
Outdated
[profile.release.package.miniz_oxide] | ||
debug = 0 | ||
[profile.release.package.gimli] | ||
debug = 0 | ||
[profile.release.package.addr2line] | ||
debug = 0 | ||
[profile.release.package.object] | ||
debug = 0 | ||
[profile.release.package.adler] | ||
debug = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it more dense?
[profile.release.package.miniz_oxide] | |
debug = 0 | |
[profile.release.package.gimli] | |
debug = 0 | |
[profile.release.package.addr2line] | |
debug = 0 | |
[profile.release.package.object] | |
debug = 0 | |
[profile.release.package.adler] | |
debug = 0 | |
[profile.release.package] | |
miniz_oxide = { debug = 0 } | |
gimli = { debug = 0 } | |
addr2line = { debug = 0 } | |
object = { debug = 0 } | |
adler = { debug = 0 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems really unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, does TOML have the Nix thing of letting you write gimli = { debug = 0 }
as gimli.debug = 0
? IMO using the dot notation would feel more natural, but then again maybe that's personal bias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes TOML supports gimli.debug = 0
, so I've gone ahead and updated to use that.
This was evaluated in rust-lang#74560 and shown to have a positive effect on some of the regressions originally reported from rust-lang#73441. While it doesn't recover all of the lost ground this is hopefully an easy enough knob to tweak that we don't have worry too much about it later.
8a80a3e
to
3075cc3
Compare
@bors: r=Mark-Simulacrum |
📌 Commit 3075cc3 has been approved by |
@bors r- We've discussed a bit and we want to revert the (original) backtrace PR and re-land it in the next week or so, but after getting a try build that fully evaluates it plus this patch (amongst others, perhaps) to better gauge the effects on perf. |
Ok, then let's close this. |
This was evaluated in #74560 and shown to have a positive effect on some
of the regressions originally reported from #73441. While it doesn't
recover all of the lost ground this is hopefully an easy enough knob to
tweak that we don't have worry too much about it later.