-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Free more disk space with free-disk-space script #134151
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
3aa602b
to
a356fe0
Compare
a356fe0
to
2d374ca
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b7805b1
to
de0761b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
126c581
to
de0761b
Compare
Confirmed that the script behaves the same when moved to the repo, still trying to figure out if jlumbroso/free-disk-space#26 makes a tangible difference. Currently, free disk space can clean up 36GB with the changes up to this point, so a 10GB improvement so far. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d0a6385
to
ce5b7e5
Compare
This comment has been minimized.
This comment has been minimized.
0850509
to
e447a4f
Compare
This comment has been minimized.
This comment has been minimized.
|
Nope, will be reverting that one, jlumbroso/free-disk-space#26 also doesn't seem to make a noticeable improvement, especially compared to the example in that PR |
5ef7bf7
to
e0d0d4b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7e4bea1
to
f0e8e11
Compare
This comment has been minimized.
This comment has been minimized.
This reverts commit 6b53cfb.
f0e8e11
to
b291103
Compare
Attempting to move the free-disk-space github action into the repo as it isn't currently maintained. This involves moving the script within free-disk-space into the repo.
I'm opening this as a draft to verify that the saved space is the same as the original action. Once that is verified, I'll look into integrating these two PRs to improve it:
Changes so far:
free-disk-space
repo and moved it intosrc/ci/scripts/
jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be
GitHub actionSee this issue for more info: rust-lang/infra-team#183