Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch rtems target to panic unwind #133420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thesummer
Copy link
Contributor

Swtich the RTEMS target to panic_unwind.

Relates to rust-lang/backtrace-rs#682

@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@bors
Copy link
Contributor

bors commented Nov 30, 2024

☔ The latest upstream changes (presumably #133533) made this pull request unmergeable. Please resolve the merge conflicts.

@thesummer
Copy link
Contributor Author

@workingjubilee I hope the release stress from the last release is over. Could you please have a look at this PR?

Integrating it even without the update to the backtrace submodule would already help me to experiment with some unit test setups.

@tgross35
Copy link
Contributor

The changes here look reasonable to me but the backtrace changes need to merge before this right?

@thesummer
Copy link
Contributor Author

@tgross35 I think it is save to merge this one here first as well. Currently the port also requires that backtrace is updated locally, so merging this won't change that.

@tgross35
Copy link
Contributor

The backtrace change is so small that maybe we should just try to get that in around the same time. @workingjubilee is backtrace stuck from CI failures or could rust-lang/backtrace-rs#682 get into a release soonish?

@thesummer
Copy link
Contributor Author

@tgross35 Updating the backtrace submodule was blocked by some performance metrics (see this PR #130417).

I am not sure if the CI failures of rust-lang/backtrace-rs#682 are related to that.

@workingjubilee
Copy link
Member

confused. If this was all that was needed, why wasn't it just done from the get-go...?

@workingjubilee
Copy link
Member

Most of the CI failures in backtrace have nothing to do with the ruzstd merge and can simply be fixed by fixing them.

@workingjubilee
Copy link
Member

workingjubilee commented Jan 2, 2025

CI will be fixed enough when rust-lang/backtrace-rs#687 rust-lang/backtrace-rs#679 merges

@thesummer
Copy link
Contributor Author

@workingjubilee Sorry, for the confusion. I am new to rust compiler development and was working myself upwards from a bare-metal/panic abort system to RTEMS support.

Happy New Year btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants