x86 target features: make pclmulqdq imply sse2 #132174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
jieyouxu
approved these changes
Oct 26, 2024
| ("pclmulqdq", Stable, &[]), | ||
| ("pclmulqdq", Stable, &["sse2"]), |
There was a problem hiding this comment.
Based on looking at other impls, e.g. C#'s version of this https://learn.microsoft.com/en-us/dotnet/api/system.runtime.intrinsics.x86.pclmulqdq.x64?view=net-8.0, the change looks correct to me.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 26, 2024
x86 target features: make pclmulqdq imply sse2 Based on comments in rust-lang/stdarch#1661 Fixes rust-lang/stdarch#1661
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Oct 26, 2024
x86 target features: make pclmulqdq imply sse2 Based on comments in rust-lang/stdarch#1661 Fixes rust-lang/stdarch#1661
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#132124 (coverage: Consolidate creation of covmap/covfun records) - rust-lang#132167 (Replace some LLVMRust wrappers with calls to the LLVM C API) - rust-lang#132169 (Deny calls to non-`#[const_trait]` methods in MIR constck) - rust-lang#132174 (x86 target features: make pclmulqdq imply sse2) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#132124 (coverage: Consolidate creation of covmap/covfun records) - rust-lang#132140 (Enable LSX feature for LoongArch Linux targets) - rust-lang#132169 (Deny calls to non-`#[const_trait]` methods in MIR constck) - rust-lang#132174 (x86 target features: make pclmulqdq imply sse2) - rust-lang#132180 (Print unsafety of attribute in AST pretty print) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2024
Rollup merge of rust-lang#132174 - RalfJung:pclmulqdq, r=calebzulawski x86 target features: make pclmulqdq imply sse2 Based on comments in rust-lang/stdarch#1661 Fixes rust-lang/stdarch#1661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on comments in rust-lang/stdarch#1661
Fixes rust-lang/stdarch#1661