-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference for asm-goto #1693
base: master
Are you sure you want to change the base?
Conversation
@Amanieu: What do you think? |
@rustbot author |
We reviewed this in the lang call today. Everyone read through it. It looked right. Nobody had any notes. |
The asm-goto-with-outputs is still unstable, so in the reference it's still mentioned as forbidden by a check rule.
In reading this more carefully (especially the lines not changed), I find myself wanting to double check that we're being precise enough now by what we mean by "the So when we say, e.g., that...
...or...
...or...
...or even...
...do we mean for these to apply to the |
GCC manual says "Also note that an asm goto statement is always implicitly considered volatile.", although AFAIU it's possible to represent a asm-goto in LLVM without the It's not clear what exactly is pure for an asm goto block, since the control flow change is also one of its output. We probably should just forbid pure + label from being used together -- however note that since
These would just mean the assembly themselves. |
The asm-goto-with-outputs is still unstable, so in the reference it's still mentioned as forbidden by a check rule.
Stabilization PR: rust-lang/rust#133870