Skip to content

Commit

Permalink
Debug logging during s3 operations
Browse files Browse the repository at this point in the history
This is likely to be very verbose, but hopefully will eventually give us
request IDs for #77 which we can ask about to S3, or give us enough
information to fix it locally. This has broken 2 nightlies in 12 days,
which is a pretty high incidence rate so far.
  • Loading branch information
Mark-Simulacrum committed Oct 23, 2023
1 parent 19ed30b commit 43218ce
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,12 @@ impl Context {
fn aws_s3(&self) -> Command {
let mut cmd = Command::new("aws");

// Log request IDs while we investigate an error coming from S3:
// [SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1007)
//
// See https://github.com/rust-lang/promote-release/issues/77 for tracking for this.
cmd.arg("--debug");

// Allow using non-S3 backends with the AWS CLI.
if let Some(url) = &self.config.s3_endpoint_url {
cmd.arg("--endpoint-url");
Expand Down

0 comments on commit 43218ce

Please sign in to comment.