Simplify Swizzle trait #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the const generics failures for now--I filed an issue in rust-lang/rust#116320 |
programmerjake
approved these changes
Oct 2, 2023
calebzulawski
force-pushed
the
simpler-swizzle-trait
branch
from
ae72c87 to
e16e42e
Compare
calebzulawski
force-pushed
the
simpler-swizzle-trait
branch
from
e16e42e to
6e0de19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible answer to the questions about swizzles raised in #364. This API isn't necessary perfect, but it's now a single unobtrusive trait that's relatively easy to use.
Swizzleis no longer parameterized by the input lengthSwizzle2andWhichbySwizzle::concat_swizzleconst {}blocks