Implement blocking unnamed_socket #4072
Merged
+391
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-author
|
Planning to open a minor clean-up PR to remove some unused variable here before getting back to this. @rustbot label S-blocked |
|
☔ The latest upstream changes (presumably #4074) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
reviewed
Dec 6, 2024
oli-obk
reviewed
Dec 6, 2024
oli-obk
reviewed
Dec 13, 2024
tiif
commented
Dec 14, 2024
tiif
commented
Dec 16, 2024
Comment on lines
+172
to
+173
| let Some(self_ref) = weak_self_ref.upgrade() else { | ||
| // FIXME: We should raise a deadlock error if the self_ref upgrade failed. | ||
| throw_unsup_format!("This will be a deadlock error in future") | ||
| }; |
There was a problem hiding this comment.
I think this PR is big enough, so I decided to temporarily make this throws unsupported format.
I wanted to write a test for this, and potentially tweak the diagnostic a bit if it is too confusing (because of the reason stated here).
But I certainly won't mind putting it in this PR if anyone prefers.
|
@rustbot ready |
rustbot
added
S-waiting-on-review
oli-obk
requested changes
Dec 18, 2024
oli-obk
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support blocking for socketpair and pipe.
closes #3665