sysconf interception fix for solarish systems. #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Nov 22, 2024
also adding the `_SC_PAGESIZE` alias `_SC_PAGE_SIZE` supported by Linux, macOS and FreeBSD. close rust-lang#4050
|
LGTM! Why is this marked as a draft? @rustbot author |
rustbot
added
the
S-waiting-on-author
|
Ah, please also change |
|
Please squash whenever you think the PR is ready (and mark it as ready, and do |
|
Also your system clock seems to be completely off, github says you committed that "enable solaris CI" change 19 hours ago. Would be nice if you could fix your clock so that things are less confusing. :) |
|
@rustbot ready |
rustbot
removed
the
S-waiting-on-author
|
Thanks for the quick fix :) |
devnexen
added a commit
to devnexen/miri
that referenced
this pull request
Nov 23, 2024
devnexen
added a commit
to devnexen/miri
that referenced
this pull request
Nov 24, 2024
devnexen
added a commit
to devnexen/miri
that referenced
this pull request
Nov 24, 2024
devnexen
added a commit
to devnexen/miri
that referenced
this pull request
Nov 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2024
follow-up on #4052, making a miri evaluation context fn for strerror_r.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adding the
_SC_PAGESIZEalias_SC_PAGE_SIZEsupported by Linux, macOS and FreeBSD.close #4050