Add -Zmiri-env-set to set environment variables without modifying the host environment
#3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't rustc have some flag to sent env vars nowadays? Should we just reuse that instead of adding our own? |
|
I'm not aware of such flag |
|
rust-lang/compiler-team#653 was the decision to add it. Tracking issue is at rust-lang/rust#118372, so it seems to have been implemented. |
|
Do we want the same flag for compile-time |
RalfJung
reviewed
Apr 21, 2024
RalfJung
reviewed
Apr 21, 2024
Fair, I guess it makes sense to treat them separately. |
…he host environment This option allows to pass environment variables to the interpreted program without needing to modify the host environment (which may have undesired effects in some cases).
oli-obk
requested changes
Apr 23, 2024
oli-obk
approved these changes
Apr 23, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows to pass environment variables to the interpreted program without needing to modify the host environment (which may have undesired effects in some cases).