Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extern crate #2503

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Extern crate #2503

wants to merge 8 commits into from

Conversation

bobhy
Copy link

@bobhy bobhy commented Dec 10, 2024

Allows doc tests to freely reference external crates in use statements.
Avoids depending on unstable Cargo interfaces to determine dependencies by the
simple expedient of running a cargo build --verbose and observing how Cargo invoked the compiler.
Includes necessary doc changes and some gratuitous rewrites as well.

New Writing Doc Tests chapter includes code sample using serde which compiles and runs, though running mdbook test on the whole guide yields many errors.

Fixes #706 and #394.
Edit: does not address issue 768.

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Dec 10, 2024
@bobhy
Copy link
Author

bobhy commented Dec 10, 2024

I'm dependent on feature file_set_times, which was stabilized in rust v 1.76. You are currently on 1.74. What is the schedule for updating your MSRV?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to reference 3rd-party crates
2 participants