-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux_like: unify SIGEV_THREAD_ID support #3661
base: main
Are you sure you want to change the base?
linux_like: unify SIGEV_THREAD_ID support #3661
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
2fd26c6
to
1c292ff
Compare
(Should be merged after we upgrade musl header on CI). |
1c292ff
to
bddd7aa
Compare
bddd7aa
to
01829ec
Compare
For reference, should be mergeable after this PR: #3068. |
@rustbot blocked |
This effectively adds the constant for musl too, as last platform of this category. It has been supported in musl since 7c71792e ("add support for SIGEV_THREAD_ID timers") and was released with v1.2.2 in January 2021. Also double-checked that the `sigevent` struct is defined in the exact same way. Signed-off-by: Christoph Heiss <[email protected]>
01829ec
to
9272dc5
Compare
☔ The latest upstream changes (presumably #4132) made this pull request unmergeable. Please resolve the merge conflicts. |
This has been supported in musl since release v1.2.2 in January 2021. See also the commit in musl itself.
Not sure about emscripten though - I guess without gating it, it would be enabled there too?
As this is my first contribution, please just holler if something is off.