-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dl_iterate_phdr to some BSD OSs #1953
Conversation
r? @JohnTitor (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
456f1bf
to
2058e37
Compare
Done. CI should be green! |
I just tested it on OpenBSD, and it failed due to `p_type` error. Adding a `cfg.skip_field` section as for freebsd makes the tests to pass on OpenBSD.
Could you add it inside test_openbsd() ? Else I will correct it after your PR to be commited.
Thanks to have provided the types and function on OpenBSD !
|
3e869ee
to
fd8bb24
Compare
tests are fine on OpenBSD. thanks ! |
624f531
to
5c23d75
Compare
Looks like it works: rust-lang/rust#78184 (comment). |
Looks good to me, thanks! |
📌 Commit 5c23d75 has been approved by |
Add dl_iterate_phdr to some BSD OSs Add dl_iterate_phdr for freebsd, openbsd and netbsd: #1066 cc rust-lang/backtrace-rs#325
💔 Test failed - checks-actions |
The failure is:
Ah, anyway we should "use" them here. |
* Include some header files * Ingore tests for p_type field of `Elf*_Phdr` because of conflicting with p_type macro from resolve.h
5c23d75
to
be37f01
Compare
I'm sorry. I made a mistake in netbsd code. The diff of change is 5c23d75...be37f01 . |
@bors r+ |
📌 Commit be37f01 has been approved by |
Add dl_iterate_phdr to some BSD OSs Add dl_iterate_phdr for freebsd, openbsd and netbsd: #1066 cc rust-lang/backtrace-rs#325
💔 Test failed - checks-actions |
What is this error? https://github.com/rust-lang/libc/runs/1314551399#step:5:1496
|
The second error is unrelated, |
@bors retry |
Add dl_iterate_phdr to some BSD OSs Add dl_iterate_phdr for freebsd, openbsd and netbsd: #1066 cc rust-lang/backtrace-rs#325
@bors retry |
Can we create a new patch release for this PR ? |
Add dl_iterate_phdr for freebsd, openbsd and netbsd: #1066
cc rust-lang/backtrace-rs#325